Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1440683003: gfx: Remove gfx::NativeEditView. (Closed)

Created:
5 years, 1 month ago by sadrul
Modified:
5 years, 1 month ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gfx: Remove gfx::NativeEditView. There is only one use left for NativeEditView for content-shell on mac. So remove the NativeEditView typedef on all platforms, and instead explicitly use NSTextField for content-shell on mac. BUG=500004 Committed: https://crrev.com/8b11d2650f933e26dda39f6e8832c986056f5eef Cr-Commit-Position: refs/heads/master@{#359337}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M content/shell/browser/shell.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/shell/browser/shell.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/native_widget_types.h View 4 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sadrul
5 years, 1 month ago (2015-11-12 01:31:03 UTC) #2
Peter Beverloo
lgtm
5 years, 1 month ago (2015-11-12 14:03:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440683003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440683003/1
5 years, 1 month ago (2015-11-12 18:16:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 18:41:43 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:08:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b11d2650f933e26dda39f6e8832c986056f5eef
Cr-Commit-Position: refs/heads/master@{#359337}

Powered by Google App Engine
This is Rietveld 408576698