Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1341)

Issue 1440663003: Add "growable" parameter to List.filled constructor. (Closed)

Created:
5 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
5 years, 1 month ago
Reviewers:
floitsch, kevmoo
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add "growable" parameter to List.filled constructor. Fixes issue #24884 BUG= http://dartbug.com/24884 R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/50aa43569d892b3e395a812cdb2a42e66069c1be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M runtime/lib/array_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/core_patch.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M sdk/lib/core/list.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M tests/corelib/growable_list_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/list_filled_type_argument_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/corelib/list_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Lasse Reichstein Nielsen
WDYT? Seems all functions that create lists end up needing this parameter. That suggests we ...
5 years, 1 month ago (2015-11-12 12:32:23 UTC) #2
floitsch
LGTM.
5 years, 1 month ago (2015-11-12 18:17:12 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 50aa43569d892b3e395a812cdb2a42e66069c1be (presubmit successful).
5 years, 1 month ago (2015-11-13 08:30:50 UTC) #4
kevmoo
CHANGELOG!
5 years, 1 month ago (2015-11-13 18:46:16 UTC) #6
Lasse Reichstein Nielsen
5 years, 1 month ago (2015-11-18 11:46:18 UTC) #8
Message was sent while issue was closed.
CHANGELOG.md updated in separate CL.

Powered by Google App Engine
This is Rietveld 408576698