Certificate Transparency: Per-profile CT verification

net/cert/ct_verifier.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_CT_VERIFIER_H_
 #define NET_CERT_CT_VERIFIER_H_
 
 #include <string>
 
 #include "net/base/net_export.h"
 
 namespace net {
 
 namespace ct {
 struct CTVerifyResult;
 struct SignedCertificateTimestamp;
 }  // namespace ct
 
 class BoundNetLog;
 class CTLogVerifier;
 class X509Certificate;
 
 // Interface for verifying Signed Certificate Timestamps over a certificate.
+// The only known (non-test) implementation currently is MultiLogCTVerifier.
 class NET_EXPORT CTVerifier {
  public:
   class NET_EXPORT Observer {
    public:
     // Called for each Signed Certificate Timestamp from a known log that vas
     // verified successfully (i.e. the signature verifies). |sct| is the
     // Signed Certificate Timestamp, |cert| is the certificate it applies to.
     // The certificate is needed to calculate the hash of the log entry,
     // necessary for checking inclusion in the log.
+    // Note: The observer may store the observed |cert| and |sct|, which are
+    // tied to a specific user profile, so it must be profile-specific.

[mmenke, 2015/11/20 17:23:58]

It's a layering violation for net/ to know about profiles...  So wait, this is
solely a (potential) property of the (Not yet written) Observers, and not the
MultiCTVerifier itself?

[Eran Messeri, 2015/11/23 12:34:38]

Correct - the observer implementation will live outside net/ (in
components/certificate_transparency)  and will be aware of profiles. Hopefully
that is sensible?
(Likely that the observer implementation will only get the URLRequestContext and
storage  path from the profile and will not be tightly coupled with code in
chrome/browser/profiles)

I have amended the documentation to reflect that.

     virtual void OnSCTVerified(X509Certificate* cert,
                                const ct::SignedCertificateTimestamp* sct) = 0;
   };
 
   virtual ~CTVerifier() {}
 
   // Verifies SCTs embedded in the certificate itself, SCTs embedded in a
   // stapled OCSP response, and SCTs obtained via the
   // signed_certificate_timestamp TLS extension on the given |cert|.
   // A certificate is permitted but not required to use multiple sources for
@@ skipping 12 matching lines @@
   // Registers |observer| to receive notifications of validated SCTs. Does not
   // take ownership of the observer as the observer may be performing
   // URLRequests which have to be cancelled before this object is destroyed.
   // Setting |observer| to nullptr has the effect of stopping all notifications.
   virtual void SetObserver(Observer* observer) = 0;
 };
 
 }  // namespace net
 
 #endif  // NET_CERT_CT_VERIFIER_H_