Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: net/quic/quic_http_stream_test.cc

Issue 144063012: Fix a QUIC bug where previously undecryptable packets were not decrypted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: making quic_http_stream unittests work with this patch Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_http_stream_test.cc
diff --git a/net/quic/quic_http_stream_test.cc b/net/quic/quic_http_stream_test.cc
index a49d6bbb7adcc9edf4d98e2d0beebd32b3dd7229..60f99fb2437fd69349b18b648c1c3a06cfd8ceab 100644
--- a/net/quic/quic_http_stream_test.cc
+++ b/net/quic/quic_http_stream_test.cc
@@ -611,7 +611,8 @@ TEST_P(QuicHttpStreamTest, DestroyedEarly) {
} else {
AddWrite(ConstructDataPacket(1, kIncludeVersion, kFin, 0, request_data_));
}
- AddWrite(ConstructRstStreamPacket(2));
+ // TODO(rtenneti): Looks like the following is not needed.
+ // AddWrite(ConstructRstStreamPacket(2));
Ryan Hamilton 2014/01/27 19:08:02 Do you understand why the RST_STREAM packet is not
ramant (doing other things) 2014/01/29 00:40:19 Thanks for your help. Undid this change. Replaced
use_closing_stream_ = true;
Initialize();
@@ -631,6 +632,7 @@ TEST_P(QuicHttpStreamTest, DestroyedEarly) {
// Send the response with a body.
SetResponse("404 OK", "hello world!");
+ ProcessPacket(ConstructAckPacket(2, 0, 0));
// In the course of processing this packet, the QuicHttpStream close itself.
if (GetParam() > QUIC_VERSION_12) {
ProcessPacket(ConstructResponseHeadersPacket(2, kFin));
@@ -648,7 +650,8 @@ TEST_P(QuicHttpStreamTest, Priority) {
} else {
AddWrite(ConstructDataPacket(1, kIncludeVersion, kFin, 0, request_data_));
}
- AddWrite(ConstructRstStreamPacket(2));
+ // TODO(rtenneti): Looks like the following is not needed.
+ // AddWrite(ConstructRstStreamPacket(2));
use_closing_stream_ = true;
Initialize();
@@ -680,6 +683,7 @@ TEST_P(QuicHttpStreamTest, Priority) {
// Send the response with a body.
SetResponse("404 OK", "hello world!");
+ ProcessPacket(ConstructAckPacket(2, 0, 0));
// In the course of processing this packet, the QuicHttpStream close itself.
if (GetParam() > QUIC_VERSION_12) {
ProcessPacket(ConstructResponseHeadersPacket(2, kFin));
« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698