Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: net/quic/quic_connection.h

Issue 144063012: Fix a QUIC bug where previously undecryptable packets were not decrypted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: upload changes Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_connection.cc » ('j') | net/quic/quic_framer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.h
diff --git a/net/quic/quic_connection.h b/net/quic/quic_connection.h
index c7b34b759a7d9e664d26ec0ab1087156d2589a1c..136a96e7174b82ef8a8339cbea8ab61d48306494 100644
--- a/net/quic/quic_connection.h
+++ b/net/quic/quic_connection.h
@@ -578,13 +578,16 @@ class NET_EXPORT_PRIVATE QuicConnection
// Update the |sent_info| for an outgoing ack.
void UpdateSentPacketInfo(SentPacketInfo* sent_info);
+ // Queues an ack or sets the ack alarm when an incoming packet arrives that
+ // should be acked.
+ void MaybeQueueAck();
+
// Checks if the last packet should instigate an ack.
bool ShouldLastPacketInstigateAck();
// Sends any packets which are a response to the last packet, including both
// acks and pending writes if an ack opened the congestion window.
- void MaybeSendInResponseToPacket(bool send_ack_immediately,
- bool last_packet_should_instigate_ack);
+ void MaybeSendInResponseToPacket();
// Get the FEC group associate with the last processed packet or NULL, if the
// group has already been deleted.
@@ -647,6 +650,9 @@ class NET_EXPORT_PRIVATE QuicConnection
QuicReceivedPacketManager received_packet_manager_;
QuicSentEntropyManager sent_entropy_manager_;
+ // Indicates whether an ack should be sent the next time we try to write.
+ bool ack_queued_;
+
// An alarm that fires when an ACK should be sent to the peer.
scoped_ptr<QuicAlarm> ack_alarm_;
// An alarm that fires when a packet needs to be retransmitted.
« no previous file with comments | « no previous file | net/quic/quic_connection.cc » ('j') | net/quic/quic_framer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698