Fix a QUIC bug where previously undecryptable packets were not decrypted

net/quic/quic_packet_creator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_packet_creator.h"
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "net/quic/crypto/quic_random.h"
 #include "net/quic/quic_ack_notifier.h"
@@ skipping 403 matching lines @@
   header->fec_group = fec_group;
 }
 
 bool QuicPacketCreator::ShouldRetransmit(const QuicFrame& frame) {
   return frame.type != ACK_FRAME && frame.type != CONGESTION_FEEDBACK_FRAME &&
       frame.type != PADDING_FRAME;
 }
 
 bool QuicPacketCreator::AddFrame(const QuicFrame& frame,
                                  bool save_retransmittable_frames) {
+#ifndef NDEBUG
+  if (frame.type == ACK_FRAME) {

[Ryan Hamilton, 2014/01/29 00:52:52]

nit:I think I would use a switch statement here.  You might want to consider
adding an operator<< method to QuicFrame which actually does this.  Then you
could remove the #ifdef:

DVLOG(1) << "Adding: " << frame;

[ramant (doing other things), 2014/01/29 02:45:38]

Done.

+    DVLOG(1) << "AddFrame ACK_FRAME: " << *(frame.ack_frame);
+  } else if (frame.type == RST_STREAM_FRAME) {
+    DVLOG(1) << "AddFrame RST_STREAM_FRAME: " << *(frame.rst_stream_frame);
+  } else if (frame.type == STREAM_FRAME) {
+    DVLOG(1) << "AddFrame STREAM_FRAME: " << *(frame.stream_frame);
+  }
+#endif
+
   size_t frame_len = framer_->GetSerializedFrameLength(
       frame, BytesFree(), queued_frames_.empty(), true,
       options()->send_sequence_number_length);
   if (frame_len == 0) {
     return false;
   }
   DCHECK_LT(0u, packet_size_);
   MaybeStartFEC();
   packet_size_ += frame_len;
   // If the last frame in the packet was a stream frame, then once we add the
@@ skipping 37 matching lines @@
   if (!is_handshake) {
     return;
   }
 
   QuicPaddingFrame padding;
   bool success = AddFrame(QuicFrame(&padding), false);
   DCHECK(success);
 }
 
 }  // namespace net