Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 144063007: Fixed the bracket and the missing type, introduced by https://codereview.chromium.org/139743016 (Closed)

Created:
6 years, 11 months ago by whywhat
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fixed the bracket and the missing type, introduced by https://codereview.chromium.org/139743016 BUG=None NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246903

Patch Set 1 #

Patch Set 2 : Rebased, bracket seems to be fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all_android.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
whywhat
PTaL
6 years, 11 months ago (2014-01-24 16:06:58 UTC) #1
Michael van Ouwerkerk
lgtm
6 years, 11 months ago (2014-01-24 16:13:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avayvod@chromium.org/144063007/1
6 years, 11 months ago (2014-01-24 16:19:22 UTC) #3
commit-bot: I haz the power
Failed to apply patch for build/all_android.gyp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-24 16:19:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avayvod@chromium.org/144063007/60001
6 years, 11 months ago (2014-01-24 16:30:49 UTC) #5
commit-bot: I haz the power
Change committed as 246903
6 years, 11 months ago (2014-01-24 16:31:10 UTC) #6
whywhat
6 years, 11 months ago (2014-01-24 16:38:30 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/143523013/ by avayvod@chromium.org.

The reason for reverting is: bauerb fixed it before me but I was using the
pinned revision so missed the fix..

Powered by Google App Engine
This is Rietveld 408576698