Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 144063002: Scope our ANNOTATE_BENIGN_RACE. (Closed)

Created:
6 years, 11 months ago by mtklein
Modified:
6 years, 11 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Scope our ANNOTATE_BENIGN_RACE. This should unstick the DEPS roll. When building with TSAN, Chromium's pulling in the canonical one from dynamic_annotations.h, and we're trying to redefine it. TBR=reed@google.com BUG= Committed: http://code.google.com/p/skia/source/detail?r=13129

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M include/core/SkOnce.h View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
6 years, 11 months ago (2014-01-21 14:24:05 UTC) #1
robertphillips
lgtm
6 years, 11 months ago (2014-01-21 14:24:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/144063002/1
6 years, 11 months ago (2014-01-21 14:36:11 UTC) #3
commit-bot: I haz the power
Presubmit check for 144063002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 11 months ago (2014-01-21 14:36:14 UTC) #4
bsalomon
lgtm
6 years, 11 months ago (2014-01-21 14:37:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/144063002/1
6 years, 11 months ago (2014-01-21 14:38:30 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-21 15:11:05 UTC) #7
Message was sent while issue was closed.
Change committed as 13129

Powered by Google App Engine
This is Rietveld 408576698