Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1410)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkPage.java

Issue 1440623004: [Enhanced Bookmark]Rewrite initialization logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address fgorski's comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkPage.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkPage.java
index f30da93fc4e34acc8d7bcaeccf4ad60b75a4ec10..889be8c99717ffaa05c89b18d886ec53a9172b27 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkPage.java
@@ -29,6 +29,7 @@ public class EnhancedBookmarkPage implements NativePage, EnhancedBookmarkStateCh
private final int mBackgroundColor;
private final int mThemeColor;
private EnhancedBookmarkManager mManager;
+ private String mCurrentUrl;
/**
* Create a new instance of an enhanced bookmark page.
@@ -97,6 +98,7 @@ public class EnhancedBookmarkPage implements NativePage, EnhancedBookmarkStateCh
@Override
public void updateForUrl(String url) {
+ mCurrentUrl = url;
mManager.updateForUrl(url);
}
@@ -108,6 +110,7 @@ public class EnhancedBookmarkPage implements NativePage, EnhancedBookmarkStateCh
@Override
public void onBookmarkUIStateChange(String url) {
+ if (url.equals(mCurrentUrl)) return;
Kibeom Kim (inactive) 2015/11/19 19:18:19 Q: 1. how does this interact with refresh? 2. What
Ian Wen 2015/12/01 09:17:14 It eliminates the loop that EB changes its url and
newt (away) 2015/12/01 19:53:19 Actually, refresh will cause the page to be recrea
mTab.loadUrl(new LoadUrlParams(url));
}
}

Powered by Google App Engine
This is Rietveld 408576698