ash/wm/system_modal_container_layout_manager_unittest.cc - Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/system_modal_container_layout_manager_unittest.cc

Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: scopedptrequals: operators-review Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/wm/system_modal_container_layout_manager_unittest.cc

diff --git a/ash/wm/system_modal_container_layout_manager_unittest.cc b/ash/wm/system_modal_container_layout_manager_unittest.cc

index 7273f6f9205ae6551d9632f55f7cfba6a63067f1..1d2eaa73c0d2c17bbf6171d40bc2786251b17ba0 100644

--- a/ash/wm/system_modal_container_layout_manager_unittest.cc

+++ b/ash/wm/system_modal_container_layout_manager_unittest.cc

@@ -275,7 +275,7 @@ TEST_F(SystemModalContainerLayoutManagerTest, ModalNonTransient) {

EXPECT_TRUE(wm::IsActiveWindow(t2));

- EXPECT_EQ(t1, ::wm::GetTransientParent(t2));

+ EXPECT_EQ(t1.get(), ::wm::GetTransientParent(t2));

EXPECT_EQ(GetModalContainer(), t2->parent());

// t2 should still be active, even after clicking on t1.

« no previous file with comments | « ash/wm/system_gesture_event_filter_unittest.cc ('k') | ash/wm/workspace/workspace_window_resizer_unittest.cc » ('j') | base/memory/scoped_ptr.h » ('J')