ui/app_list/app_list_item_list_unittest.cc - Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/app_list_item_list_unittest.cc

Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: scopedptrequals: followupfix-after-rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/app_list/app_list_item_list_unittest.cc

diff --git a/ui/app_list/app_list_item_list_unittest.cc b/ui/app_list/app_list_item_list_unittest.cc

index 92986fff9a470e43fb76d565a8e29b5df932103a..ad57f1a550c8a0840daa3530832b903f04fb2bb1 100644

--- a/ui/app_list/app_list_item_list_unittest.cc

+++ b/ui/app_list/app_list_item_list_unittest.cc

@@ -178,7 +178,7 @@ TEST_F(AppListItemListTest, RemoveItemAt) {

EXPECT_TRUE(VerifyItemListOrdinals());

scoped_ptr<AppListItem> item_removed = RemoveItemAt(1);

- EXPECT_EQ(item_removed, item_1);

+ EXPECT_EQ(item_removed.get(), item_1);

EXPECT_FALSE(FindItem(item_1->id()));

EXPECT_EQ(item_list_.item_count(), 2u);

EXPECT_EQ(observer_.items_removed(), 1u);

@@ -203,7 +203,7 @@ TEST_F(AppListItemListTest, RemoveItem) {

EXPECT_EQ(index, 1u);

scoped_ptr<AppListItem> item_removed = RemoveItem(item_1->id());

- EXPECT_EQ(item_removed, item_1);

+ EXPECT_EQ(item_removed.get(), item_1);

EXPECT_FALSE(FindItem(item_1->id()));

EXPECT_EQ(item_list_.item_count(), 2u);

EXPECT_EQ(observer_.items_removed(), 1u);

« no previous file with comments | « net/url_request/url_fetcher_core.cc ('k') | ui/aura/window.cc » ('j') | no next file with comments »