Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: content/browser/service_worker/service_worker_write_to_cache_job.cc

Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: scopedptrequals: followupfix-after-rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_write_to_cache_job.cc
diff --git a/content/browser/service_worker/service_worker_write_to_cache_job.cc b/content/browser/service_worker/service_worker_write_to_cache_job.cc
index fdd2867e49248db39ff33588fadb96778d883660..24bcd0f441a1602d8a43f93cbba54bd7d928899e 100644
--- a/content/browser/service_worker/service_worker_write_to_cache_job.cc
+++ b/content/browser/service_worker/service_worker_write_to_cache_job.cc
@@ -240,7 +240,7 @@ void ServiceWorkerWriteToCacheJob::OnReceivedRedirect(
net::URLRequest* request,
const net::RedirectInfo& redirect_info,
bool* defer_redirect) {
- DCHECK_EQ(net_request_, request);
+ DCHECK_EQ(net_request_.get(), request);
TRACE_EVENT0("ServiceWorker",
"ServiceWorkerWriteToCacheJob::OnReceivedRedirect");
// Script resources can't redirect.
@@ -252,7 +252,7 @@ void ServiceWorkerWriteToCacheJob::OnReceivedRedirect(
void ServiceWorkerWriteToCacheJob::OnAuthRequired(
net::URLRequest* request,
net::AuthChallengeInfo* auth_info) {
- DCHECK_EQ(net_request_, request);
+ DCHECK_EQ(net_request_.get(), request);
TRACE_EVENT0("ServiceWorker",
"ServiceWorkerWriteToCacheJob::OnAuthRequired");
// TODO(michaeln): Pass this thru to our jobs client.
@@ -264,7 +264,7 @@ void ServiceWorkerWriteToCacheJob::OnAuthRequired(
void ServiceWorkerWriteToCacheJob::OnCertificateRequested(
net::URLRequest* request,
net::SSLCertRequestInfo* cert_request_info) {
- DCHECK_EQ(net_request_, request);
+ DCHECK_EQ(net_request_.get(), request);
TRACE_EVENT0("ServiceWorker",
"ServiceWorkerWriteToCacheJob::OnCertificateRequested");
// TODO(michaeln): Pass this thru to our jobs client.
@@ -278,7 +278,7 @@ void ServiceWorkerWriteToCacheJob::OnSSLCertificateError(
net::URLRequest* request,
const net::SSLInfo& ssl_info,
bool fatal) {
- DCHECK_EQ(net_request_, request);
+ DCHECK_EQ(net_request_.get(), request);
TRACE_EVENT0("ServiceWorker",
"ServiceWorkerWriteToCacheJob::OnSSLCertificateError");
// TODO(michaeln): Pass this thru to our jobs client,
@@ -291,7 +291,7 @@ void ServiceWorkerWriteToCacheJob::OnSSLCertificateError(
void ServiceWorkerWriteToCacheJob::OnBeforeNetworkStart(
net::URLRequest* request,
bool* defer) {
- DCHECK_EQ(net_request_, request);
+ DCHECK_EQ(net_request_.get(), request);
TRACE_EVENT0("ServiceWorker",
"ServiceWorkerWriteToCacheJob::OnBeforeNetworkStart");
NotifyBeforeNetworkStart(defer);
@@ -299,7 +299,7 @@ void ServiceWorkerWriteToCacheJob::OnBeforeNetworkStart(
void ServiceWorkerWriteToCacheJob::OnResponseStarted(
net::URLRequest* request) {
- DCHECK_EQ(net_request_, request);
+ DCHECK_EQ(net_request_.get(), request);
if (!request->status().is_success()) {
NotifyDoneHelper(request->status(), kFetchScriptError);
return;
@@ -401,7 +401,7 @@ void ServiceWorkerWriteToCacheJob::OnWriteDataComplete(net::Error error) {
void ServiceWorkerWriteToCacheJob::OnReadCompleted(net::URLRequest* request,
int bytes_read) {
- DCHECK_EQ(net_request_, request);
+ DCHECK_EQ(net_request_.get(), request);
if (bytes_read < 0) {
DCHECK(!request->status().is_success());
NotifyDoneHelper(request->status(), kFetchScriptError);
« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/browser/web_contents/web_contents_view_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698