components/invalidation/impl/ticl_invalidation_service.cc - Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/invalidation/impl/ticl_invalidation_service.cc

Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: scopedptrequals: followupfix-after-rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/invalidation/impl/ticl_invalidation_service.cc

diff --git a/components/invalidation/impl/ticl_invalidation_service.cc b/components/invalidation/impl/ticl_invalidation_service.cc

index 43a9c9d526ebb249691853d22fa49c3dbcda00d5..6f75182ae6d598d207b798634d3720285159ca4a 100644

--- a/components/invalidation/impl/ticl_invalidation_service.cc

+++ b/components/invalidation/impl/ticl_invalidation_service.cc

@@ -205,7 +205,7 @@ void TiclInvalidationService::OnGetTokenSuccess(

const OAuth2TokenService::Request* request,

const std::string& access_token,

const base::Time& expiration_time) {

- DCHECK_EQ(access_token_request_, request);

+ DCHECK_EQ(access_token_request_.get(), request);

access_token_request_.reset();

// Reset backoff time after successful response.

request_access_token_backoff_.Reset();

@@ -220,7 +220,7 @@ void TiclInvalidationService::OnGetTokenSuccess(

void TiclInvalidationService::OnGetTokenFailure(

const OAuth2TokenService::Request* request,

const GoogleServiceAuthError& error) {

- DCHECK_EQ(access_token_request_, request);

+ DCHECK_EQ(access_token_request_.get(), request);

DCHECK_NE(error.state(), GoogleServiceAuthError::NONE);

access_token_request_.reset();

switch (error.state()) {

« no previous file with comments | « components/invalidation/impl/gcm_network_channel.cc ('k') | components/search_engines/util.cc » ('j') | no next file with comments »