ios/chrome/browser/updatable_config/updatable_config_base.mm - Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/updatable_config/updatable_config_base.mm

Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: scopedptrequals: some-more-compile-fixes Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/browser/updatable_config/updatable_config_base.mm

diff --git a/ios/chrome/browser/updatable_config/updatable_config_base.mm b/ios/chrome/browser/updatable_config/updatable_config_base.mm

index 49a793de3a897cd894b4ca34032df2e821b0a872..027f699bfc1c5e576936c9b0a1b40dab1ab698b6 100644

--- a/ios/chrome/browser/updatable_config/updatable_config_base.mm

+++ b/ios/chrome/browser/updatable_config/updatable_config_base.mm

@@ -63,7 +63,7 @@ class ConfigFetcher : public net::URLFetcherDelegate {

}

void OnURLFetchComplete(const net::URLFetcher* fetcher) override {

- DCHECK_EQ(fetcher_, fetcher);

+ DCHECK_EQ(fetcher_.get(), fetcher);

NSData* responseData = nil;

if (fetcher_->GetResponseCode() == net::HTTP_OK) {

std::string response;

« base/memory/scoped_ptr.h ('K') | « device/serial/serial_io_handler_win.cc ('k') | net/spdy/spdy_write_queue_unittest.cc » ('j') | no next file with comments »