components/invalidation/impl/gcm_network_channel.cc - Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/invalidation/impl/gcm_network_channel.cc

Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/memory/scoped_ptr.h ('K') | « components/invalidation/impl/gcm_invalidation_bridge.cc ('k') | components/invalidation/impl/ticl_invalidation_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/invalidation/impl/gcm_network_channel.cc

diff --git a/components/invalidation/impl/gcm_network_channel.cc b/components/invalidation/impl/gcm_network_channel.cc

index 7e66446480778614e0409a6afea84d3c145c5b7b..449b5f5f23d74d8a89c1cf3902ad3876022586c5 100644

--- a/components/invalidation/impl/gcm_network_channel.cc

+++ b/components/invalidation/impl/gcm_network_channel.cc

@@ -229,7 +229,7 @@ void GCMNetworkChannel::OnGetTokenComplete(

void GCMNetworkChannel::OnURLFetchComplete(const net::URLFetcher* source) {

DCHECK(CalledOnValidThread());

- DCHECK_EQ(fetcher_, source);

+ DCHECK_EQ(fetcher_.get(), source);

// Free fetcher at the end of function.

scoped_ptr<net::URLFetcher> fetcher = fetcher_.Pass();