chrome/browser/ui/app_list/search/people/people_provider.cc - Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/people/people_provider.cc

Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/memory/scoped_ptr.h ('K') | « chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_impl.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/search/people/people_provider.cc

diff --git a/chrome/browser/ui/app_list/search/people/people_provider.cc b/chrome/browser/ui/app_list/search/people/people_provider.cc

index 1677b181a7470e580f44f10cb2e4717345daa972..92d626d1d93cb2b6ec03b64aeb67ac8ba74bbea7 100644

--- a/chrome/browser/ui/app_list/search/people/people_provider.cc

+++ b/chrome/browser/ui/app_list/search/people/people_provider.cc

@@ -103,7 +103,7 @@ void PeopleProvider::OnGetTokenSuccess(

const OAuth2TokenService::Request* request,

const std::string& access_token,

const base::Time& expiration_time) {

- DCHECK_EQ(access_token_request_, request);

+ DCHECK_EQ(access_token_request_.get(), request);

access_token_request_.reset();

access_token_ = access_token;

StartQuery();

@@ -112,7 +112,7 @@ void PeopleProvider::OnGetTokenSuccess(

void PeopleProvider::OnGetTokenFailure(

const OAuth2TokenService::Request* request,

const GoogleServiceAuthError& error) {

- DCHECK_EQ(access_token_request_, request);

+ DCHECK_EQ(access_token_request_.get(), request);

access_token_request_.reset();

}