Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1440593003: [Intl] create new instances when new.target is undefined (Closed)

Created:
5 years, 1 month ago by caitp (gmail)
Modified:
5 years, 1 month ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Intl] create new instances when new.target is undefined BUG=v8:4360 LOG=N R=littledan@chromium.org Committed: https://crrev.com/fa9c39eeadd8e692af03b024fe2fdcf94ad0da6b Cr-Commit-Position: refs/heads/master@{#31971}

Patch Set 1 #

Patch Set 2 : Remove unwanted tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -39 lines) Patch
M src/js/i18n.js View 3 chunks +22 lines, -33 lines 0 comments Download
M test/test262/test262.status View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
caitp (gmail)
PTAL when you get some time, since you've been poking around ecma402 stuff lately
5 years, 1 month ago (2015-11-11 19:36:30 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440593003/1
5 years, 1 month ago (2015-11-12 19:58:21 UTC) #4
Dan Ehrenberg
lgtm Looks good, seems to match the spec by my reading. Tests look great too, ...
5 years, 1 month ago (2015-11-12 20:29:35 UTC) #5
Dan Ehrenberg
lgtm Looks good, seems to match the spec by my reading. Tests look great too, ...
5 years, 1 month ago (2015-11-12 20:29:35 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-12 20:34:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440593003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440593003/20001
5 years, 1 month ago (2015-11-12 21:16:24 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-12 21:46:11 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fa9c39eeadd8e692af03b024fe2fdcf94ad0da6b Cr-Commit-Position: refs/heads/master@{#31971}
5 years, 1 month ago (2015-11-14 23:21:06 UTC) #13
Dan Ehrenberg
5 years, 1 month ago (2015-11-24 01:54:30 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1473493003/ by littledan@chromium.org.

The reason for reverting is: This breaks backwards compatibility by disallowing
call. Web application authors have noticed the breakage.
https://github.com/tc39/ecma402/issues/57.

Powered by Google App Engine
This is Rietveld 408576698