Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1440593002: [Swarming] Isolate shared libraries for windows. (Closed)

Created:
5 years, 1 month ago by Michael Achenbach
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Swarming] Isolate shared libraries for windows. BUG=chromium:535160 LOG=n Committed: https://crrev.com/9ebd096fa3aa9cb47f5cd9bc51d06b51fba01dd7 Cr-Commit-Position: refs/heads/master@{#32114}

Patch Set 1 #

Patch Set 2 : Added icu shared libraries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/base.isolate View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Michael Achenbach
PTAL
5 years, 1 month ago (2015-11-11 13:51:28 UTC) #3
tandrii(chromium)
lgtm
5 years, 1 month ago (2015-11-11 13:57:28 UTC) #4
Michael Achenbach
FYI: This passed the staging bot which is currently defined to build with shared_libraries on ...
5 years, 1 month ago (2015-11-11 15:11:59 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440593002/20001
5 years, 1 month ago (2015-11-11 15:12:15 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-11 15:58:39 UTC) #10
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-11-11 20:43:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440593002/20001
5 years, 1 month ago (2015-11-19 13:09:58 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 13:30:31 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 13:30:57 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9ebd096fa3aa9cb47f5cd9bc51d06b51fba01dd7
Cr-Commit-Position: refs/heads/master@{#32114}

Powered by Google App Engine
This is Rietveld 408576698