Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
5 years, 1 month ago by Michael Achenbach Modified:
5 years, 1 month ago Reviewers:
Jakob Kummerow, jochen (gone - plz use gerrit), tandrii(chromium) CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Swarming] Isolate shared libraries for windows.
BUG=chromium:535160
LOG=n
Committed: https://crrev.com/9ebd096fa3aa9cb47f5cd9bc51d06b51fba01dd7
Cr-Commit-Position: refs/heads/master@{#32114}
Patch Set 1 #Patch Set 2 : Added icu shared libraries #
Created: 5 years, 1 month ago
Messages
Total messages: 16 (7 generated)
Description was changed from ========== [Swarming] Isolate v8.dll for shared library builds. BUG= ========== to ========== [Swarming] Isolate v8.dll for shared library builds. BUG=chromium:535160 LOG=n ==========
machenbach@chromium.org changed reviewers: + jkummerow@chromium.org, jochen@chromium.org, tandrii@chromium.org
PTAL
lgtm
Description was changed from ========== [Swarming] Isolate v8.dll for shared library builds. BUG=chromium:535160 LOG=n ========== to ========== [Swarming] Isolate shared libraries for windows. BUG=chromium:535160 LOG=n ==========
FYI: This passed the staging bot which is currently defined to build with shared_libraries on windows.
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440593002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org Link to the patchset: https://codereview.chromium.org/1440593002/#ps20001 (title: "Added icu shared libraries")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440593002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9ebd096fa3aa9cb47f5cd9bc51d06b51fba01dd7 Cr-Commit-Position: refs/heads/master@{#32114} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
