Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: components/signin/core/account_id/account_id.h

Issue 1440583002: This CL replaces e-mail with AccountId on user selection screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/account_id/account_id.h
diff --git a/components/signin/core/account_id/account_id.h b/components/signin/core/account_id/account_id.h
index 73be4501db5b0ab107937acced10ee17d478a5e2..6dfe18fdca431be3e47a9fff8f3b9e5d243f901d 100644
--- a/components/signin/core/account_id/account_id.h
+++ b/components/signin/core/account_id/account_id.h
@@ -45,8 +45,11 @@ class AccountId {
static AccountId FromUserEmailGaiaId(const std::string& user_email,
const std::string& gaia_id);
- // std::string Serialize() const;
- // static AccountId Deserialize(const std::string& serialized);
+ // This is (for now) unstable and cannot be used to store serialized data to
+ // persistent storage. Only in-memory storage is safe.
+ std::string Serialize() const;
+ static bool Deserialize(const std::string& serialized,
+ AccountId* out_account_id);
stevenjb 2015/11/11 20:39:23 Even if these are unstable, please document that t
Alexander Alekseev 2015/11/12 06:53:04 Done.
private:
AccountId();

Powered by Google App Engine
This is Rietveld 408576698