Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3976)

Unified Diff: chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc

Issue 1440583002: This CL replaces e-mail with AccountId on user selection screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed tests. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
index c672a2410c7a5579461e73013af56f35b32a5655..4f9579f83286b1bbcf71289178bb57c1beeac320 100644
--- a/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
@@ -18,6 +18,7 @@
#include "chrome/grit/generated_resources.h"
#include "chromeos/audio/chromeos_sounds.h"
#include "components/login/localized_values_builder.h"
+#include "components/signin/core/account_id/account_id.h"
#include "components/user_manager/user_manager.h"
#include "components/user_manager/user_type.h"
#include "google_apis/gaia/gaia_auth_util.h"
@@ -392,11 +393,14 @@ void SupervisedUserCreationScreenHandler::
}
void SupervisedUserCreationScreenHandler::HandleAuthenticateManager(
- const std::string& raw_manager_username,
+ const AccountId& manager_raw_account_id,
const std::string& manager_password) {
- const std::string manager_username =
- gaia::SanitizeEmail(raw_manager_username);
- delegate_->AuthenticateManager(manager_username, manager_password);
+ const AccountId manager_account_id = AccountId::FromUserEmailGaiaId(
+ gaia::SanitizeEmail(manager_raw_account_id.GetUserEmail()),
+ manager_raw_account_id.GetGaiaId());
+ ;
dzhioev (left Google) 2015/11/13 23:17:37 nit: remove ;
Alexander Alekseev 2015/11/14 00:27:42 Done.
+ delegate_->AuthenticateManager(manager_account_id.GetUserEmail(),
+ manager_password);
}
// TODO(antrim) : this is an explicit code duplications with UserImageScreen.

Powered by Google App Engine
This is Rietveld 408576698