Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 1440573003: Remove ScopedVector from NavigationController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl_unittest.cc
diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc
index 2e38619ceb98458edaad1b4afad561794a786cf5..186b066fec600229c5c81d546351d14b504d5c1a 100644
--- a/content/browser/web_contents/web_contents_impl_unittest.cc
+++ b/content/browser/web_contents/web_contents_impl_unittest.cc
@@ -838,7 +838,7 @@ TEST_F(WebContentsImplTest, NavigateFromRestoredSitelessUrl) {
// SiteInstance.
browser_client.set_assign_site_for_url(false);
const GURL native_url("non-site-url://stuffandthings");
- ScopedVector<NavigationEntry> entries;
+ std::vector<scoped_ptr<NavigationEntry>> entries;
scoped_ptr<NavigationEntry> new_entry =
NavigationControllerImpl::CreateNavigationEntry(
native_url, Referrer(), ui::PAGE_TRANSITION_LINK, false,
@@ -888,7 +888,7 @@ TEST_F(WebContentsImplTest, NavigateFromRestoredRegularUrl) {
// ShouldAssignSiteForUrl override is disabled (i.e. returns true).
browser_client.set_assign_site_for_url(true);
const GURL regular_url("http://www.yahoo.com");
- ScopedVector<NavigationEntry> entries;
+ std::vector<scoped_ptr<NavigationEntry>> entries;
scoped_ptr<NavigationEntry> new_entry =
NavigationControllerImpl::CreateNavigationEntry(
regular_url, Referrer(), ui::PAGE_TRANSITION_LINK, false,

Powered by Google App Engine
This is Rietveld 408576698