Remove ScopedVector from NavigationController.

Remove ScopedVector from NavigationController.

BUG=554289
TEST=none

Committed: https://crrev.com/f16f85a705cb181528cc733ddcb22bebe070b862
Cr-Commit-Position: refs/heads/master@{#359588}

[Avi (use Gerrit), 2015-11-11 20:08:49]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-11 20:10:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1440573003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1440573003/1

[commit-bot: I haz the power, 2015-11-11 20:23:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-11 20:23:54]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Avi (use Gerrit), 2015-11-11 21:40:32]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-11 21:42:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1440573003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1440573003/20001

[commit-bot: I haz the power, 2015-11-11 22:00:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-11 22:00:01]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Avi (use Gerrit), 2015-11-11 23:41:53]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-11 23:43:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1440573003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1440573003/40001

[commit-bot: I haz the power, 2015-11-12 00:07:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-12 00:07:37]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, no
build URL)
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, no build URL)
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL)

[Avi (use Gerrit), 2015-11-12 15:55:38]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-12 15:55:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1440573003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1440573003/40001

[Avi (use Gerrit), 2015-11-12 15:56:08]

avi@chromium.org changed reviewers:
+ nick@chromium.org

[commit-bot: I haz the power, 2015-11-12 16:11:34]

The CQ bit was unchecked by commit-bot@chromium.org

[Avi (use Gerrit), 2015-11-12 16:11:38]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-12 16:11:38]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)

[Avi (use Gerrit), 2015-11-12 16:22:25]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-12 16:22:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1440573003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1440573003/60001

[ncarter (slow), 2015-11-12 18:10:40]

lgtm, with some totally optional "while we're in here" reserve() suggestions.

https://codereview.chromium.org/1440573003/diff/60001/android_webview/native/...
File android_webview/native/state_serializer.cc (right):

https://codereview.chromium.org/1440573003/diff/60001/android_webview/native/...
android_webview/native/state_serializer.cc:97:
std::vector<scoped_ptr<content::NavigationEntry>> entries;
Might as well:

entries.reserve(entry_count)

?

https://codereview.chromium.org/1440573003/diff/60001/components/sessions/con...
File components/sessions/content/content_serialized_navigation_builder.cc
(right):

https://codereview.chromium.org/1440573003/diff/60001/components/sessions/con...
components/sessions/content/content_serialized_navigation_builder.cc:93:
std::vector<scoped_ptr<content::NavigationEntry>> entries;
Might as well:

entries.reserve(navigations.size());

https://codereview.chromium.org/1440573003/diff/60001/content/browser/frame_h...
File content/browser/frame_host/navigation_controller_impl.cc (right):

https://codereview.chromium.org/1440573003/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl.cc:277: needs_reload_ =
true;
Could reserve the additional capacity here too (entries_.size() +
entries.size()).

https://codereview.chromium.org/1440573003/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl.cc:280:
NavigationEntryImpl::FromNavigationEntry(entry.release()));
Could use the scoped_ptr variant of ::FromNavigationEntry here.

https://codereview.chromium.org/1440573003/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl.cc:1353: });
A dumb for loop here (using an int or size_t) would probably be simpler than a
lambda. From within the for loop, you can just return directly, eliminating the
need for the ternary operator below.

https://codereview.chromium.org/1440573003/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl.cc:1673:
entries_[last_committed_entry_index_] = entry.Pass();
Good riddance.

https://codereview.chromium.org/1440573003/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl.cc:2013:
NavigationEntryImpl::FromNavigationEntry(entry.release()));
.Pass() would also work here, which I think would let you get rid of the
entry_impl variable.

[commit-bot: I haz the power, 2015-11-12 18:41:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-12 18:41:01]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2015-11-12 19:13:05]

https://codereview.chromium.org/1440573003/diff/60001/android_webview/native/...
File android_webview/native/state_serializer.cc (right):

https://codereview.chromium.org/1440573003/diff/60001/android_webview/native/...
android_webview/native/state_serializer.cc:97:
std::vector<scoped_ptr<content::NavigationEntry>> entries;
On 2015/11/12 18:10:40, ncarter wrote:
> Might as well:
> 
> entries.reserve(entry_count)
> 
> ?

Done.

https://codereview.chromium.org/1440573003/diff/60001/components/sessions/con...
File components/sessions/content/content_serialized_navigation_builder.cc
(right):

https://codereview.chromium.org/1440573003/diff/60001/components/sessions/con...
components/sessions/content/content_serialized_navigation_builder.cc:93:
std::vector<scoped_ptr<content::NavigationEntry>> entries;
On 2015/11/12 18:10:40, ncarter wrote:
> Might as well:
> 
> entries.reserve(navigations.size());

Done.

https://codereview.chromium.org/1440573003/diff/60001/content/browser/frame_h...
File content/browser/frame_host/navigation_controller_impl.cc (right):

https://codereview.chromium.org/1440573003/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl.cc:277: needs_reload_ =
true;
On 2015/11/12 18:10:40, ncarter wrote:
> Could reserve the additional capacity here too (entries_.size() +
> entries.size()).

entries_ is supposed to be empty (and is DCHECKed) so I'll simplify.

https://codereview.chromium.org/1440573003/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl.cc:280:
NavigationEntryImpl::FromNavigationEntry(entry.release()));
On 2015/11/12 18:10:40, ncarter wrote:
> Could use the scoped_ptr variant of ::FromNavigationEntry here.

WHY DID I FORGET THAT EXISTED

https://codereview.chromium.org/1440573003/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl.cc:1353: });
On 2015/11/12 18:10:40, ncarter wrote:
> A dumb for loop here (using an int or size_t) would probably be simpler than a
> lambda. From within the for loop, you can just return directly, eliminating
the
> need for the ternary operator below.

Done.

https://codereview.chromium.org/1440573003/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl.cc:1673:
entries_[last_committed_entry_index_] = entry.Pass();
On 2015/11/12 18:10:40, ncarter wrote:
> Good riddance.

Acknowledged.

https://codereview.chromium.org/1440573003/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl.cc:2013:
NavigationEntryImpl::FromNavigationEntry(entry.release()));
On 2015/11/12 18:10:40, ncarter wrote:
> .Pass() would also work here, which I think would let you get rid of the
> entry_impl variable.

Done.

[Avi (use Gerrit), 2015-11-12 19:13:24]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-12 19:14:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1440573003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1440573003/80001

[Avi (use Gerrit), 2015-11-12 19:16:37]

avi@chromium.org changed reviewers:
+ dfalcantara@chromium.org, mnaganov@chromium.org, pkasting@chromium.org,
skuhne@chromium.org

[Avi (use Gerrit), 2015-11-12 19:16:38]

mnaganov@chromium.org: Please review changes in aw

dfalcantara@chromium.org: Please review changes in other android stuff

skuhne@chromium.org: Please review changes in components

pkasting@chromium.org: Please review changes in chrome/browser/ui

[mnaganov (inactive), 2015-11-12 19:46:44]

android_webview/ LGTM

[commit-bot: I haz the power, 2015-11-12 21:15:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-12 21:15:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gone, 2015-11-12 21:33:40]

lgtm for other android stuff

[ncarter (slow), 2015-11-12 23:56:59]

lgtm

https://codereview.chromium.org/1440573003/diff/80001/content/browser/frame_h...
File content/browser/frame_host/navigation_controller_impl.cc (right):

https://codereview.chromium.org/1440573003/diff/80001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl.cc:1349: return i;
Huh, I'm surprised this works -- I didn't think implicit conversion from size_t
to int was possible.

[Peter Kasting, 2015-11-13 00:11:47]

LGTM

[Avi (use Gerrit), 2015-11-13 15:23:30]

avi@chromium.org changed reviewers:
+ sky@chromium.org
- skuhne@chromium.org

[Avi (use Gerrit), 2015-11-13 15:23:31]

Scott, can you take components/sessions for review?

[sky, 2015-11-13 16:33:21]

LGTM

https://codereview.chromium.org/1440573003/diff/80001/components/sessions/con...
File components/sessions/content/content_serialized_navigation_builder.cc
(right):

https://codereview.chromium.org/1440573003/diff/80001/components/sessions/con...
components/sessions/content/content_serialized_navigation_builder.cc:99: return
entries;
The new world is going to take some getting use to...

[Avi (use Gerrit), 2015-11-13 17:52:51]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2015-11-13 17:53:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1440573003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1440573003/80001

[commit-bot: I haz the power, 2015-11-13 18:25:10]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-13 18:25:52]

Patchset 5 (id:??) landed as
https://crrev.com/f16f85a705cb181528cc733ddcb22bebe070b862
Cr-Commit-Position: refs/heads/master@{#359588}