Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 1440553002: Oilpan: add temporary plugin ignore exemption for DataRef<T>::RefPtr<T>. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: add temporary plugin ignore exemption for DataRef<T>::RefPtr<T>. Until the clang Blink GC plugin has been updated to include r359074, the GC plugin will erroneously complain if DataRef<T> is used with a RefCountedGarbageCollected<T> class type. Add a GC_PLUGIN_IGNORE() to temporarily prevent such false errors from being reported. R= BUG=553613 Committed: https://crrev.com/4419f282c80376075dc2f9efb3adfee41f9289c2 Cr-Commit-Position: refs/heads/master@{#359094}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/core/style/DataRef.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sof
please take a look.
5 years, 1 month ago (2015-11-11 12:05:45 UTC) #2
Yuta Kitamura
(non-owner) LGTM.
5 years, 1 month ago (2015-11-11 14:21:59 UTC) #4
haraken
LGTM
5 years, 1 month ago (2015-11-11 16:10:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440553002/1
5 years, 1 month ago (2015-11-11 16:11:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 16:15:47 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 19:57:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4419f282c80376075dc2f9efb3adfee41f9289c2
Cr-Commit-Position: refs/heads/master@{#359094}

Powered by Google App Engine
This is Rietveld 408576698