Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 1440423002: [heap] Do not require kRingBufferMaxSize samples for estimating compaction speed (Closed)

Created:
5 years, 1 month ago by Michael Lippautz
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Do not require kRingBufferMaxSize samples for estimating compaction speed There is no need to require kRingbufferMaxSize samples for estimating the compaction speed, as the number is already quite stable with a single sample (which may include timings from compacting multiple pages). R=hpayer@chromium.org BUG=chromium:524425 LOG=N Committed: https://crrev.com/c0d310bdf8b4a17c7dd08c69f83ddae3b9a3151a Cr-Commit-Position: refs/heads/master@{#31993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/gc-tracer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Hannes Payer (out of office)
lgtm
5 years, 1 month ago (2015-11-13 20:06:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440423002/1
5 years, 1 month ago (2015-11-13 20:07:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 20:25:10 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:21:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0d310bdf8b4a17c7dd08c69f83ddae3b9a3151a
Cr-Commit-Position: refs/heads/master@{#31993}

Powered by Google App Engine
This is Rietveld 408576698