Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 14404012: Change deprecated comments that still talk about SCons. (Closed)

Created:
7 years, 8 months ago by Michael Starzinger
Modified:
7 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Change deprecated comments that still talk about SCons. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14387

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments by Jakob Kummerow. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -114 lines) Patch
M src/version.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/check-static-initializers.sh View 1 chunk +0 lines, -1 line 0 comments Download
M tools/js2c.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/test-server.py View 1 1 chunk +0 lines, -9 lines 0 comments Download
M tools/utils.py View 1 1 chunk +0 lines, -98 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
You can delete even more stuffs :-) LGTM if you skip that for now and ...
7 years, 8 months ago (2013-04-22 17:30:15 UTC) #1
Michael Starzinger
PTAL. Deleting more stuff is always good. :) https://codereview.chromium.org/14404012/diff/1/src/version.cc File src/version.cc (right): https://codereview.chromium.org/14404012/diff/1/src/version.cc#newcode43 src/version.cc:43: // ...
7 years, 8 months ago (2013-04-23 08:41:16 UTC) #2
Jakob Kummerow
LGTM. (I wonder why Rietveld shows utils.py's status as "M" rather than "D", but I ...
7 years, 8 months ago (2013-04-23 08:53:35 UTC) #3
Michael Starzinger
7 years, 8 months ago (2013-04-23 08:58:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r14387 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698