chromeos/dbus/ibus/ibus_engine_service.h - Issue 14404007: Fix crash on extension IME reloading on Linux Desktop with chromeos=1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/ibus/ibus_engine_service.h

Issue 14404007: Fix crash on extension IME reloading on Linux Desktop with chromeos=1. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressing comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/ibus/ibus_engine_service.h

diff --git a/chromeos/dbus/ibus/ibus_engine_service.h b/chromeos/dbus/ibus/ibus_engine_service.h

index 6dd7f6d43c291784860f5819a0efcb69dc54ecc2..da986d57a83b4b14aeb4b00d9e831f91f61594f1 100644

--- a/chromeos/dbus/ibus/ibus_engine_service.h

+++ b/chromeos/dbus/ibus/ibus_engine_service.h

@@ -116,8 +116,9 @@ class CHROMEOS_EXPORT IBusEngineService {

// This class doesn't take the ownership of |handler|.

virtual void SetEngine(IBusEngineHandlerInterface* handler) = 0;

- // Unsets the current IBus engine handler.

- virtual void UnsetEngine() = 0;

+ // Unsets the IBus engine handler if |handler| equals to current engine

+ // handler.

+ virtual void UnsetEngine(IBusEngineHandlerInterface* handler) = 0;

// Emits RegisterProperties signal.

virtual void RegisterProperties(