Issue 14404005: Add d8 functionality for switching between realms (a.k.a. contexts), 2nd try

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14404005: Add d8 functionality for switching between realms (a.k.a. contexts), 2nd try (Closed)

Created:
7 years, 8 months ago by rossberg

Modified:
7 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add d8 functionality for switching between realms (a.k.a. contexts), 2nd try The only difference to the previous implementation (https://codereview.chromium.org/14295011/) is in patch set 2. R=yangguo@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=14373

Patch Set 2 : Bracket realms init/clean-up using RealmScope class #

Total comments: 2

Patch Set 3 : Make realms work again interactively #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+342 lines, -121 lines)			Patch
M	src/d8.h	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/d8.cc	View	1 2	24 chunks	+294 lines, -76 lines	0 comments	Download
M	src/debug.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/objects.h	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/bugs/bug-proto.js	View		1 chunk	+34 lines, -43 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

https://codereview.chromium.org/14404005/diff/2001/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/14404005/diff/2001/src/d8.cc#newcode299 src/d8.cc:299: for (int i = 0; i < data_->realm_count_; ++i) ...

7 years, 8 months ago (2013-04-22 11:22:19 UTC) #1

Yang

On 2013/04/22 11:22:19, Yang wrote: > https://codereview.chromium.org/14404005/diff/2001/src/d8.cc > File src/d8.cc (right): > > https://codereview.chromium.org/14404005/diff/2001/src/d8.cc#newcode299 > ...

7 years, 8 months ago (2013-04-22 11:22:38 UTC) #2

rossberg

7 years, 8 months ago (2013-04-22 11:30:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r14373 (presubmit successful).