Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart

Issue 14404004: Throw NoSuchMethod or ArgumentError instead of generating a bailout, when we know the next instruct… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart (revision 21808)
+++ sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart (working copy)
@@ -186,7 +186,10 @@
// Update the pending optimizations map based on the potentially
// new types of the operands. If the operand types no longer allow
// us to optimize, we remove the pending optimization.
- if (instruction.specializer is BinaryArithmeticSpecializer) {
+ InvokeDynamicSpecializer specializer = instruction.specializer;
+ if (specializer is BinaryArithmeticSpecializer
kasperl 2013/04/23 06:12:43 Add a method on the specializer?
ngeoffray 2013/04/23 08:06:04 Done.
+ || (specializer is RelationalSpecializer
+ && specializer is !EqualsSpecializer)) {
HInstruction left = instruction.inputs[1];
HInstruction right = instruction.inputs[2];
if (left.isNumber() && !right.isNumber()) {
@@ -315,7 +318,7 @@
}
HType computeDesiredType(HInstruction instruction) {
- HType desiredType = HType.UNKNOWN;
+ HType desiredType = instruction.instructionType;
for (final user in instruction.usedBy) {
HType userDesiredType = desiredTypeVisitor.computeDesiredTypeForInput(
user, instruction);

Powered by Google App Engine
This is Rietveld 408576698