Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart

Issue 14404004: Throw NoSuchMethod or ArgumentError instead of generating a bailout, when we know the next instruct… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart (revision 21808)
+++ sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart (working copy)
@@ -108,7 +108,8 @@
void visitTypeConversion(HTypeConversion instruction) {
if (!instruction.isChecked) {
markAsGenerateAtUseSite(instruction);
- } else if (!instruction.isArgumentTypeCheck) {
+ } else if (!instruction.isArgumentTypeCheck
+ && !instruction.isReceiverTypeCheck) {
assert(instruction.isCheckedModeCheck || instruction.isCastTypeCheck);
// Checked mode checks and cast checks compile to code that
// only use their input once, so we can safely visit them

Powered by Google App Engine
This is Rietveld 408576698