content/renderer/devtools/devtools_agent.cc - Issue 1440383002: [DevTools] Move InspectElement call after OpenDevToolsWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/devtools/devtools_agent.cc

Issue 1440383002: [DevTools] Move InspectElement call after OpenDevToolsWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/devtools/devtools_agent.cc

diff --git a/content/renderer/devtools/devtools_agent.cc b/content/renderer/devtools/devtools_agent.cc

index d464b15b941472d2355343dbe50ebf0338cfbf2c..847a26d9edc82e9d424a969de0122dbc9cde60fb 100644

--- a/content/renderer/devtools/devtools_agent.cc

+++ b/content/renderer/devtools/devtools_agent.cc

@@ -220,9 +220,8 @@ void DevToolsAgent::OnInspectElement(

const std::string& host_id, int x, int y) {

dgozman 2015/11/16 17:15:02 Let's kill the host_id parameter.

kozy 2015/11/17 00:25:51 Done.

WebDevToolsAgent* web_agent = GetWebAgent();

if (web_agent) {

- web_agent->attach(WebString::fromUTF8(host_id));

+ DCHECK(is_attached_);

dgozman 2015/11/16 17:15:02 Similar check would be nice if RFDTAH.

kozy 2015/11/17 00:25:51 Done.

web_agent->inspectElementAt(WebPoint(x, y));

- is_attached_ = true;

}

« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | no next file » | no next file with comments »