Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3874)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 1440383002: [DevTools] Move InspectElement call after OpenDevToolsWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index 0943fa8ba3ff4193da41628032f88c7a34865e0f..aeee74f50474089d17acb3b2d1fd2450aa9d6d53 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -520,7 +520,6 @@ void DevToolsWindow::InspectElement(
int y) {
scoped_refptr<DevToolsAgentHost> agent(
DevToolsAgentHost::GetOrCreateFor(inspected_frame_host));
- agent->InspectElement(x, y);
bool should_measure_time = FindDevToolsWindow(agent.get()) == NULL;
base::TimeTicks start_time = base::TimeTicks::Now();
// TODO(loislo): we should initiate DevTools window opening from within
@@ -532,6 +531,8 @@ void DevToolsWindow::InspectElement(
agent);
}
+ agent->InspectElement(x, y);
+
DevToolsWindow* window = FindDevToolsWindow(agent.get());
if (should_measure_time && window)
window->inspect_element_start_time_ = start_time;
« no previous file with comments | « no previous file | content/renderer/devtools/devtools_agent.cc » ('j') | content/renderer/devtools/devtools_agent.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698