Change extensions enum presubmit checks to run on upload only

Change extensions enum presubmit checks to run on upload only

This reverts commit 64749d907f25d5cb7241b90be42a22d52b4c02bc
to re-enable extensions enum presubmit checks, but makes them
run on upload only so false positives don't block commits.

BUG=555540
R=thakis@chromium.org,rdevlin.cronin@chromium.org
TBR=phajdan.jr@chromium.org

Committed: https://crrev.com/39a7fbf4435ec5ac461eedc721b7f22a70b287aa
Cr-Commit-Position: refs/heads/master@{#359572}

[Ken Rockot(use gerrit already), 2015-11-13 16:54:47]

Description was changed from

==========
Change extensions enum presubmit checks to run on upload only

This reverts commit 64749d907f25d5cb7241b90be42a22d52b4c02bc
to re-enable extensions enum presubmit checks, but makes them
run on upload only so false positives don't block commits.

BUG=555540
R=phajdan.jr@chromium.org,rdevlin.cronin@chromium.org
==========

to

==========
Change extensions enum presubmit checks to run on upload only

This reverts commit 64749d907f25d5cb7241b90be42a22d52b4c02bc
to re-enable extensions enum presubmit checks, but makes them
run on upload only so false positives don't block commits.

BUG=555540
R=thakis@chromium.org,rdevlin.cronin@chromium.org
TBR=phajdan.jr@chromium.org
==========

[Ken Rockot(use gerrit already), 2015-11-13 16:54:47]

rockot@chromium.org changed reviewers:
+ thakis@chromium.org
- phajdan.jr@chromium.org

[Devlin, 2015-11-13 17:00:27]

On 2015/11/13 16:55:02, Ken Rockot wrote:

Blast from the past!
https://codereview.chromium.org/1020663002/
;)

lgtm so we get the presubmit check back in there asap.  But I think it's worth
doing this right at some point and recognizing DELETED_ as a valid change, and
still blocking CQ.

[Nico, 2015-11-13 17:09:40]

please also add a tools/strict_enum_value_checker/OWNERS

Wasn't it the case that presubmit errors blocked cq but presubmit warnings
didn't? did that change?

[Nico, 2015-11-13 17:10:18]

(but rs-lgtm with OWNERS file)

[Ken Rockot(use gerrit already), 2015-11-13 17:16:53]

On 2015/11/13 at 17:00:27, rdevlin.cronin wrote:
> On 2015/11/13 16:55:02, Ken Rockot wrote:
> 
> Blast from the past!
> https://codereview.chromium.org/1020663002/
> ;)

Ha!

> 
> lgtm so we get the presubmit check back in there asap.  But I think it's worth
doing this right at some point and recognizing DELETED_ as a valid change, and
still blocking CQ.

Agreed.

[Ken Rockot(use gerrit already), 2015-11-13 17:17:10]

On 2015/11/13 at 17:09:40, thakis wrote:
> please also add a tools/strict_enum_value_checker/OWNERS
> 

Done.

> Wasn't it the case that presubmit errors blocked cq but presubmit warnings
didn't? did that change?

I also thought that was the case.

[Ken Rockot(use gerrit already), 2015-11-13 17:17:21]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2015-11-13 17:17:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1440343003/#ps20001
(title: "OWNERS")

[commit-bot: I haz the power, 2015-11-13 17:17:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1440343003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1440343003/20001

[commit-bot: I haz the power, 2015-11-13 17:29:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-13 17:30:16]

Patchset 2 (id:??) landed as
https://crrev.com/39a7fbf4435ec5ac461eedc721b7f22a70b287aa
Cr-Commit-Position: refs/heads/master@{#359572}