Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 144033007: IDL compiler: ForMainWorld for method arguments (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: ForMainWorld for method arguments Remaining: 4 => 3 BUG=239771 R=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166472

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -40 lines) Patch
M Source/bindings/scripts/unstable/v8_methods.py View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 3 chunks +6 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/TestInterfaceNode.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/idls/TestObjectPython.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.cpp View 2 chunks +37 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 3 chunks +37 lines, -37 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
6 years, 10 months ago (2014-02-05 08:30:29 UTC) #1
haraken
LGTM
6 years, 10 months ago (2014-02-05 08:32:34 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-05 08:35:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/144033007/1
6 years, 10 months ago (2014-02-05 08:35:46 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 08:36:19 UTC) #5
Message was sent while issue was closed.
Change committed as 166472

Powered by Google App Engine
This is Rietveld 408576698