Issue 144033004: Cast: Replace string+int x2 with net::IPEndPoint in CastTransportConfig.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 144033004: Cast: Replace string+int x2 with net::IPEndPoint in CastTransportConfig. (Closed)

Created:
6 years, 10 months ago by hubbe

Modified:
6 years, 10 months ago

Reviewers:
pwestin

CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Replace string+int x2 with net::IPEndPoint in CastTransportConfig. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247757

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -24 lines)			Patch
M	media/cast/test/sender.cc	View	2 chunks	+11 lines, -4 lines	0 comments	Download
M	media/cast/transport/cast_transport_config.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	media/cast/transport/cast_transport_config.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	media/cast/transport/pacing/paced_sender.cc	View	2 chunks	+2 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pwestin

lgtm with one nit: please add "Cast: " in the beginning of the subject description.

6 years, 10 months ago (2014-01-29 00:46:13 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/144033004/1

6 years, 10 months ago (2014-01-29 18:27:35 UTC) #3

Message was sent while issue was closed.

Change committed as 247757

Expand Messages | Collapse Messages