Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: chrome/browser/ui/browser.cc

Issue 1440303002: Componentize SecurityStateModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android/cros fixes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 14de5c7c953315aa988b50d49b6cfb55a777cbcc..0b161016e226a3194adfb63e64deae43087b8795 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -76,7 +76,7 @@
#include "chrome/browser/sessions/session_service_factory.h"
#include "chrome/browser/sessions/session_tab_helper.h"
#include "chrome/browser/sessions/tab_restore_service_factory.h"
-#include "chrome/browser/ssl/security_state_model.h"
+#include "chrome/browser/ssl/chrome_security_state_model_delegate.h"
#include "chrome/browser/sync/profile_sync_service_factory.h"
#include "chrome/browser/sync/sync_ui_util.h"
#include "chrome/browser/tab_contents/retargeting_details.h"
@@ -162,6 +162,7 @@
#include "components/favicon/content/content_favicon_driver.h"
#include "components/history/core/browser/top_sites.h"
#include "components/search/search.h"
+#include "components/security_state/security_state_model.h"
#include "components/sessions/core/session_types.h"
#include "components/sessions/core/tab_restore_service.h"
#include "components/startup_metric_utils/browser/startup_metric_utils.h"
@@ -258,20 +259,20 @@ bool IsFastTabUnloadEnabled() {
}
// Note: This is a lossy operation. Not all of the policies that can be
-// expressed by a SecurityLevel (a //chrome concept) can be expressed by
-// a content::SecurityStyle.
+// expressed by a SecurityLevel can be expressed by a
+// content::SecurityStyle.
content::SecurityStyle SecurityLevelToSecurityStyle(
- SecurityStateModel::SecurityLevel security_level) {
+ security_state::SecurityLevel security_level) {
switch (security_level) {
- case SecurityStateModel::NONE:
+ case security_state::NONE:
return content::SECURITY_STYLE_UNAUTHENTICATED;
- case SecurityStateModel::SECURITY_WARNING:
- case SecurityStateModel::SECURITY_POLICY_WARNING:
+ case security_state::SECURITY_WARNING:
+ case security_state::SECURITY_POLICY_WARNING:
return content::SECURITY_STYLE_WARNING;
- case SecurityStateModel::EV_SECURE:
- case SecurityStateModel::SECURE:
+ case security_state::EV_SECURE:
+ case security_state::SECURE:
return content::SECURITY_STYLE_AUTHENTICATED;
- case SecurityStateModel::SECURITY_ERROR:
+ case security_state::SECURITY_ERROR:
return content::SECURITY_STYLE_AUTHENTICATION_BROKEN;
}
@@ -1313,18 +1314,21 @@ bool Browser::CanDragEnter(content::WebContents* source,
content::SecurityStyle Browser::GetSecurityStyle(
WebContents* web_contents,
content::SecurityStyleExplanations* security_style_explanations) {
- SecurityStateModel* model = SecurityStateModel::FromWebContents(web_contents);
- DCHECK(model);
- const SecurityStateModel::SecurityInfo& security_info =
- model->GetSecurityInfo();
+ ChromeSecurityStateModelDelegate* model_delegate =
+ ChromeSecurityStateModelDelegate::FromWebContents(web_contents);
+ DCHECK(model_delegate);
+ const security_state::SecurityInfo& security_info =
+ model_delegate->GetSecurityInfo();
const content::SecurityStyle security_style =
SecurityLevelToSecurityStyle(security_info.security_level);
security_style_explanations->ran_insecure_content_style =
- SecurityStateModel::kRanInsecureContentStyle;
+ SecurityLevelToSecurityStyle(
+ security_state::SecurityStateModel::kRanInsecureContentLevel);
security_style_explanations->displayed_insecure_content_style =
- SecurityStateModel::kDisplayedInsecureContentStyle;
+ SecurityLevelToSecurityStyle(
+ security_state::SecurityStateModel::kDisplayedInsecureContentLevel);
// Check if the page is HTTP; if so, no explanations are needed. Note
// that SECURITY_STYLE_UNAUTHENTICATED does not necessarily mean that
@@ -1340,14 +1344,14 @@ content::SecurityStyle Browser::GetSecurityStyle(
}
if (security_info.sha1_deprecation_status ==
- SecurityStateModel::DEPRECATED_SHA1_MAJOR) {
+ security_state::DEPRECATED_SHA1_MAJOR) {
security_style_explanations->broken_explanations.push_back(
content::SecurityStyleExplanation(
l10n_util::GetStringUTF8(IDS_MAJOR_SHA1),
l10n_util::GetStringUTF8(IDS_MAJOR_SHA1_DESCRIPTION),
security_info.cert_id));
} else if (security_info.sha1_deprecation_status ==
- SecurityStateModel::DEPRECATED_SHA1_MINOR) {
+ security_state::DEPRECATED_SHA1_MINOR) {
security_style_explanations->unauthenticated_explanations.push_back(
content::SecurityStyleExplanation(
l10n_util::GetStringUTF8(IDS_MINOR_SHA1),
@@ -1356,15 +1360,14 @@ content::SecurityStyle Browser::GetSecurityStyle(
}
security_style_explanations->ran_insecure_content =
+ security_info.mixed_content_status == security_state::RAN_MIXED_CONTENT ||
security_info.mixed_content_status ==
- SecurityStateModel::RAN_MIXED_CONTENT ||
- security_info.mixed_content_status ==
- SecurityStateModel::RAN_AND_DISPLAYED_MIXED_CONTENT;
+ security_state::RAN_AND_DISPLAYED_MIXED_CONTENT;
security_style_explanations->displayed_insecure_content =
security_info.mixed_content_status ==
- SecurityStateModel::DISPLAYED_MIXED_CONTENT ||
+ security_state::DISPLAYED_MIXED_CONTENT ||
security_info.mixed_content_status ==
- SecurityStateModel::RAN_AND_DISPLAYED_MIXED_CONTENT;
+ security_state::RAN_AND_DISPLAYED_MIXED_CONTENT;
if (net::IsCertStatusError(security_info.cert_status)) {
base::string16 error_string = base::UTF8ToUTF16(net::ErrorToString(
@@ -1386,7 +1389,7 @@ content::SecurityStyle Browser::GetSecurityStyle(
// deprecated SHA1, then add an explanation that the certificate is
// valid.
if (security_info.sha1_deprecation_status ==
- SecurityStateModel::NO_DEPRECATED_SHA1) {
+ security_state::NO_DEPRECATED_SHA1) {
security_style_explanations->secure_explanations.push_back(
content::SecurityStyleExplanation(
l10n_util::GetStringUTF8(IDS_VALID_SERVER_CERTIFICATE),
« no previous file with comments | « chrome/browser/ui/android/website_settings_popup_android.cc ('k') | chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698