Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 1440303002: Componentize SecurityStateModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android/cros fixes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_browser_tests.cc
diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc
index 1d7e7c89fbc47cea3673a0928e72bbb9e9421bf0..064730bdd566d01481a98f740baf9b45a461a3de 100644
--- a/chrome/browser/ssl/ssl_browser_tests.cc
+++ b/chrome/browser/ssl/ssl_browser_tests.cc
@@ -29,9 +29,9 @@
#include "chrome/browser/ssl/cert_report_helper.h"
#include "chrome/browser/ssl/cert_verifier_browser_test.h"
#include "chrome/browser/ssl/certificate_reporting_test_utils.h"
+#include "chrome/browser/ssl/chrome_security_state_model_delegate.h"
#include "chrome/browser/ssl/chrome_ssl_host_state_delegate.h"
#include "chrome/browser/ssl/common_name_mismatch_handler.h"
-#include "chrome/browser/ssl/security_state_model.h"
#include "chrome/browser/ssl/ssl_blocking_page.h"
#include "chrome/browser/ssl/ssl_error_handler.h"
#include "chrome/browser/ui/browser.h"
@@ -47,6 +47,7 @@
#include "chrome/test/base/ui_test_utils.h"
#include "components/content_settings/core/browser/host_content_settings_map.h"
#include "components/security_interstitials/core/metrics_helper.h"
+#include "components/security_state/security_state_model.h"
#include "components/ssl_errors/error_classification.h"
#include "components/variations/variations_associated_data.h"
#include "components/web_modal/web_contents_modal_dialog_manager.h"
@@ -1081,22 +1082,27 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, TestMarkNonSecureAs) {
browser()->tab_strip_model()->GetActiveWebContents();
ASSERT_TRUE(contents);
- SecurityStateModel* model = SecurityStateModel::FromWebContents(contents);
- ASSERT_TRUE(model);
+ ChromeSecurityStateModelDelegate* model_delegate =
+ ChromeSecurityStateModelDelegate::FromWebContents(contents);
+ ASSERT_TRUE(model_delegate);
ui_test_utils::NavigateToURL(browser(), GURL("file:/"));
- EXPECT_EQ(SecurityStateModel::NONE, model->GetSecurityInfo().security_level);
+ EXPECT_EQ(security_state::NONE,
+ model_delegate->GetSecurityInfo().security_level);
ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));
- EXPECT_EQ(SecurityStateModel::NONE, model->GetSecurityInfo().security_level);
+ EXPECT_EQ(security_state::NONE,
+ model_delegate->GetSecurityInfo().security_level);
ui_test_utils::NavigateToURL(browser(), GURL("data:text/plain,hello"));
- EXPECT_EQ(SecurityStateModel::NONE, model->GetSecurityInfo().security_level);
+ EXPECT_EQ(security_state::NONE,
+ model_delegate->GetSecurityInfo().security_level);
ui_test_utils::NavigateToURL(
browser(),
GURL("blob:chrome%3A//newtab/49a463bb-fac8-476c-97bf-5d7076c3ea1a"));
- EXPECT_EQ(SecurityStateModel::NONE, model->GetSecurityInfo().security_level);
+ EXPECT_EQ(security_state::NONE,
+ model_delegate->GetSecurityInfo().security_level);
}
#if defined(USE_NSS_CERTS)
« no previous file with comments | « chrome/browser/ssl/security_state_model_unittest.cc ('k') | chrome/browser/ui/android/bluetooth_chooser_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698