src/x64/assembler-x64.cc - Issue 14403015: Disallow dereferencing deferred handles when generating optimized code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64.cc

Issue 14403015: Disallow dereferencing deferred handles when generating optimized code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/assembler-x64.cc

diff --git a/src/x64/assembler-x64.cc b/src/x64/assembler-x64.cc

index 25979f93652a942811df4ee0e62f429d1deef81f..802696b54f3a4c3e0fdf64f4fdfe2eeaff4512da 100644

--- a/src/x64/assembler-x64.cc

+++ b/src/x64/assembler-x64.cc

@@ -1590,6 +1590,7 @@ void Assembler::movl(const Operand& dst, Label* src) {

void Assembler::movq(Register dst, Handle<Object> value, RelocInfo::Mode mode) {

+ ALLOW_HANDLE_DEREF(isolate(), "using and embedding raw address");

// If there is no relocation info, emit the value of the handle efficiently

// (possibly using less that 8 bytes for the value).

if (RelocInfo::IsNone(mode)) {

« src/isolate.cc ('K') | « src/objects.cc ('k') | src/x64/lithium-codegen-x64.h » ('j') | no next file with comments »