src/factory.cc - Issue 14403015: Disallow dereferencing deferred handles when generating optimized code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 14403015: Disallow dereferencing deferred handles when generating optimized code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 77d22006a6aed9dfdca1a581644a87f85d2ce7da..fee750d345fd45c6d044b740e0a9c4daebde5bac 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -476,6 +476,7 @@ Handle<ExternalArray> Factory::NewExternalArray(int length,

Handle<JSGlobalPropertyCell> Factory::NewJSGlobalPropertyCell(

Handle<Object> value) {

+ ALLOW_HANDLE_DEREF("converting a handle into a global property cell");

CALL_HEAP_FUNCTION(

isolate(),

isolate()->heap()->AllocateJSGlobalPropertyCell(*value),

« no previous file with comments | « src/compiler.cc ('k') | src/handles.h » ('j') | src/handles.h » ('J')