Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: Source/core/dom/custom/CustomElement.cpp

Issue 144023016: Separate Custom Element resolution and upgrade/createdCallback. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/dom/custom/CustomElementCallbackInvocation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/custom/CustomElement.cpp
diff --git a/Source/core/dom/custom/CustomElement.cpp b/Source/core/dom/custom/CustomElement.cpp
index cc80568260855b08671f58db7bf46b1f479c47fa..8884873bc349cf70f7fa61526cab3c09a3efaaa5 100644
--- a/Source/core/dom/custom/CustomElement.cpp
+++ b/Source/core/dom/custom/CustomElement.cpp
@@ -106,12 +106,7 @@ void CustomElement::define(Element* element, PassRefPtr<CustomElementDefinition>
case Element::WaitingForUpgrade:
definitions().add(element, definition);
- if (element->inDocument() && element->document().domWindow())
- CustomElementScheduler::scheduleAttachedCallback(definition->callbacks(), element);
- // FIXME: Push this through the callback scheduler. That
- // design makes resolve and define robust to being called
- // during other operations.
- definition->callbacks()->created(element);
+ CustomElementScheduler::scheduleCreatedCallback(definition->callbacks(), element);
break;
}
}
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/dom/custom/CustomElementCallbackInvocation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698