Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 144023010: Remove unused geolocation code from TestRunner and WebTestProxy. (Closed)

Created:
6 years, 11 months ago by Michael van Ouwerkerk
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove unused geolocation code from TestRunner and WebTestProxy. This is a followup to patch 141163008 BUG=336263 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -74 lines) Patch
M content/shell/renderer/test_runner/TestRunner.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/shell/renderer/test_runner/TestRunner.cpp View 3 chunks +0 lines, -42 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestProxy.h View 5 chunks +0 lines, -9 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestProxy.cpp View 4 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Michael van Ouwerkerk
Tim as Geolocation owner, Adam as test_runner owner.
6 years, 11 months ago (2014-01-22 14:21:03 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 11 months ago (2014-01-22 14:22:20 UTC) #2
Michael van Ouwerkerk
Thanks Jochen :-) Removing Adam.
6 years, 11 months ago (2014-01-22 14:24:06 UTC) #3
timvolodine
lgtm
6 years, 11 months ago (2014-01-22 18:14:31 UTC) #4
abarth-chromium
lgtm
6 years, 11 months ago (2014-01-22 19:46:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/144023010/1
6 years, 11 months ago (2014-01-23 12:10:58 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-23 13:52:28 UTC) #7
Message was sent while issue was closed.
Change committed as 246589

Powered by Google App Engine
This is Rietveld 408576698