Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: src/mips/lithium-codegen-mips.cc

Issue 144023009: Get rid of the unused native code StringAddStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove obsolete StringHelper methods. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved.7 1 // Copyright 2012 the V8 project authors. All rights reserved.7
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4426 matching lines...) Expand 10 before | Expand all | Expand 10 after
4437 Label no_memento_found; 4437 Label no_memento_found;
4438 __ TestJSArrayForAllocationMemento(object, temp, &no_memento_found, 4438 __ TestJSArrayForAllocationMemento(object, temp, &no_memento_found,
4439 ne, &no_memento_found); 4439 ne, &no_memento_found);
4440 DeoptimizeIf(al, instr->environment()); 4440 DeoptimizeIf(al, instr->environment());
4441 __ bind(&no_memento_found); 4441 __ bind(&no_memento_found);
4442 } 4442 }
4443 4443
4444 4444
4445 void LCodeGen::DoStringAdd(LStringAdd* instr) { 4445 void LCodeGen::DoStringAdd(LStringAdd* instr) {
4446 ASSERT(ToRegister(instr->context()).is(cp)); 4446 ASSERT(ToRegister(instr->context()).is(cp));
4447 if (FLAG_new_string_add) { 4447 ASSERT(ToRegister(instr->left()).is(a1));
4448 ASSERT(ToRegister(instr->left()).is(a1)); 4448 ASSERT(ToRegister(instr->right()).is(a0));
4449 ASSERT(ToRegister(instr->right()).is(a0)); 4449 StringAddStub stub(instr->hydrogen()->flags(),
4450 NewStringAddStub stub(instr->hydrogen()->flags(), 4450 isolate()->heap()->GetPretenureMode());
4451 isolate()->heap()->GetPretenureMode()); 4451 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
4452 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
4453 } else {
4454 __ push(ToRegister(instr->left()));
4455 __ push(ToRegister(instr->right()));
4456 StringAddStub stub(instr->hydrogen()->flags());
4457 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
4458 }
4459 } 4452 }
4460 4453
4461 4454
4462 void LCodeGen::DoStringCharCodeAt(LStringCharCodeAt* instr) { 4455 void LCodeGen::DoStringCharCodeAt(LStringCharCodeAt* instr) {
4463 class DeferredStringCharCodeAt V8_FINAL : public LDeferredCode { 4456 class DeferredStringCharCodeAt V8_FINAL : public LDeferredCode {
4464 public: 4457 public:
4465 DeferredStringCharCodeAt(LCodeGen* codegen, LStringCharCodeAt* instr) 4458 DeferredStringCharCodeAt(LCodeGen* codegen, LStringCharCodeAt* instr)
4466 : LDeferredCode(codegen), instr_(instr) { } 4459 : LDeferredCode(codegen), instr_(instr) { }
4467 virtual void Generate() V8_OVERRIDE { 4460 virtual void Generate() V8_OVERRIDE {
4468 codegen()->DoDeferredStringCharCodeAt(instr_); 4461 codegen()->DoDeferredStringCharCodeAt(instr_);
(...skipping 1353 matching lines...) Expand 10 before | Expand all | Expand 10 after
5822 __ Subu(scratch, result, scratch); 5815 __ Subu(scratch, result, scratch);
5823 __ lw(result, FieldMemOperand(scratch, 5816 __ lw(result, FieldMemOperand(scratch,
5824 FixedArray::kHeaderSize - kPointerSize)); 5817 FixedArray::kHeaderSize - kPointerSize));
5825 __ bind(&done); 5818 __ bind(&done);
5826 } 5819 }
5827 5820
5828 5821
5829 #undef __ 5822 #undef __
5830 5823
5831 } } // namespace v8::internal 5824 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698