Issue 144023002: MIPS: Stay in fast enum case if the empty_slow_element_dictionary is used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 144023002: MIPS: Stay in fast enum case if the empty_slow_element_dictionary is used. (Closed)

Created:
6 years, 11 months ago by kilvadyb

Modified:
6 years, 11 months ago

Reviewers:
Paul Lind, danno, kisg, palfia, Toon Verwaest, dusmil

CC:
v8-dev

Base URL:
https://github.com/v8/v8.git@gbl

Visibility:
Public.

More Reviews

Description

MIPS: Stay in fast enum case if the empty_slow_element_dictionary is used. Port r18705 (78b4ea3) Original commit message: This fixes slow for-in over frozen objects. BUG=

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	src/mips/macro-assembler-mips.cc	View		1 chunk	+7 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

LGTM. https://codereview.chromium.org/144023002/diff/1/src/mips/macro-assembler-mips.cc File src/mips/macro-assembler-mips.cc (right): https://codereview.chromium.org/144023002/diff/1/src/mips/macro-assembler-mips.cc#newcode5557 src/mips/macro-assembler-mips.cc:5557: // Check that there are no elements. Register ...

6 years, 11 months ago (2014-01-21 17:46:12 UTC) #2

Committed as r18721.

Expand Messages | Collapse Messages