Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4157)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/new_new_tab.js

Issue 144022: Removes some duplicated code to use LocalStrings formatString instead... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/new_tab.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/new_new_tab.js
===================================================================
--- chrome/browser/resources/new_new_tab.js (revision 18989)
+++ chrome/browser/resources/new_new_tab.js (working copy)
@@ -560,10 +560,7 @@
function formatTabsText(numTabs) {
if (numTabs == 1)
return localStrings.getString('closedwindowsingle');
- // TODO(arv): Update grd file to use %s so we can use formatString
- // http://crbug.com/14878
- // return localStrings.formatString('closedwindowmultiple', numTabs);
- return localStrings.getString('closedwindowmultiple').replace(/%/, numTabs);
+ return localStrings.formatString('closedwindowmultiple', numTabs);
}
/**
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/new_tab.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698