Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 14402014: Print ProfileNode id when dumping CPU profile to console (Closed)

Created:
7 years, 8 months ago by yurys
Modified:
7 years, 8 months ago
Reviewers:
Sven Panne, alph, loislo
CC:
v8-dev
Visibility:
Public.

Description

Print ProfileNode id when dumping CPU profile to console Node ids are monotonically increasing and looking at them we can say e.g. when the node was added before another one. We need this to diagnose sporadic failures of cctest/test-cpu-profiler/CollectCpuProfile BUG=v8:2628 Committed: https://code.google.com/p/v8/source/detail?r=14386

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/profile-generator.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
7 years, 8 months ago (2013-04-22 16:58:08 UTC) #1
Sven Panne
lgtm
7 years, 8 months ago (2013-04-23 06:44:10 UTC) #2
yurys
7 years, 8 months ago (2013-04-23 07:26:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14386 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698