Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 1440183003: Update 145 DOM doc links to use proper Markdown; fix 56 broken links (Closed)

Created:
5 years, 1 month ago by srawlins
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update 145 DOM doc links to use proper Markdown; fix 56 broken links BUG= https://github.com/dart-lang/sdk/issues/23601 Tested with dartdoc package at HEAD with new markdown package 0.9. Looks great. R=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/974b461235021bf9530ea0f9fcc6dc95a276f74c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1275 lines, -1355 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 131 chunks +470 lines, -496 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 112 chunks +424 lines, -451 lines 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/dom/docs/docs.json View 112 chunks +379 lines, -408 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
srawlins
This CL should fix the last of https://github.com/dart-lang/sdk/issues/23601 The gist is changing markdown links with ...
5 years, 1 month ago (2015-11-13 17:05:23 UTC) #2
sethladd
Are these links generated by some tool?
5 years, 1 month ago (2015-11-13 17:07:31 UTC) #4
srawlins
On 2015/11/13 17:07:31, sethladd wrote: > Are these links generated by some tool? From alan, ...
5 years, 1 month ago (2015-11-13 17:09:20 UTC) #5
Alan Knight
lgtm Very nice.
5 years, 1 month ago (2015-11-13 18:13:09 UTC) #6
srawlins
5 years, 1 month ago (2015-11-13 19:43:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
974b461235021bf9530ea0f9fcc6dc95a276f74c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698