Extensions: Replace PO2TS::GetPrimaryAccountId() with SMB::GetAuthenticatedAccountId.

Extensions: Replace PO2TS::GetPrimaryAccountId() with SMB::GetAuthenticatedAccountId.

The functionality is the same, just moving the code to a new place.

BUG=333995
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248894

[Roger Tawa OOO till Jul 10th, 2014-02-04 18:19:32]

Hi Daniel, Michael,

Daniel: Please review changes in push messaging.

Michael: Please review changes in the identity files.

Thanks.

[Michael Courage, 2014-02-04 19:27:36]

lgtm

[dcheng, 2014-02-04 22:37:20]

Similar question about cleanups for the other files touched by this patch. Will
POA2TS be replaced by SMB completely?

https://codereview.chromium.org/144013009/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/push_messaging/push_messaging_api.cc (right):

https://codereview.chromium.org/144013009/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/push_messaging/push_messaging_api.cc:194:
ProfileOAuth2TokenServiceFactory::GetForProfile(GetProfile());
Can all references to POA2TSF be deleted from this file and the includes
removed?

[Roger Tawa OOO till Jul 10th, 2014-02-05 01:00:49]

Thanks Daniel.  SMB will not completely replace PO2TS.  Only this one method is
being removed from PO2TS.  Only one file in this CL has SMB completely replace
PO2TS, where I removed all references to the token service including headers and
such.

https://codereview.chromium.org/144013009/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/push_messaging/push_messaging_api.cc (right):

https://codereview.chromium.org/144013009/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/push_messaging/push_messaging_api.cc:194:
ProfileOAuth2TokenServiceFactory::GetForProfile(GetProfile());
On 2014/02/04 22:37:21, dcheng wrote:
> Can all references to POA2TSF be deleted from this file and the includes
> removed?

Nope.  You can see that the token service is still use at line 197 below and
several other places in the file.

[dcheng, 2014-02-05 01:03:26]

OK, thanks for the explanation. LGTM.

[Roger Tawa OOO till Jul 10th, 2014-02-05 01:33:31]

The CQ bit was checked by rogerta@chromium.org

[commit-bot: I haz the power, 2014-02-05 03:51:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rogerta@chromium.org/144013009/1

[commit-bot: I haz the power, 2014-02-05 07:11:31]

Change committed as 248894