chrome/browser/resources/ntp4/incognito_tab.html - Issue 1440113002: [MD] Change appearance of incognito NTP to MD spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/ntp4/incognito_tab.html

Issue 1440113002: [MD] Change appearance of incognito NTP to MD spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cant remember if i changed anything Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/ntp4/incognito_and_guest_tab.css ('K') | « chrome/browser/resources/ntp4/incognito_tab.css ('k') | chrome/browser/resources/ntp4/new_incognito_tab_theme.css » ('j') | chrome/browser/resources/ntp4/new_tab.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/ntp4/incognito_tab.html

diff --git a/chrome/browser/resources/ntp4/incognito_tab.html b/chrome/browser/resources/ntp4/incognito_tab.html

index 276d854b1d9bdb55c22a8eb0d5d4294daebb9cab..c5d9ab1c29c88c39626647e6fb45596c07612247 100644

--- a/chrome/browser/resources/ntp4/incognito_tab.html

+++ b/chrome/browser/resources/ntp4/incognito_tab.html

@@ -1,5 +1,6 @@

<!doctype html>

<html i18n-values="dir:textdirection;

+ hasCustomBackground:hasCustomBackground;

bookmarkbarattached:bookmarkbarattached;

lang:language">

<head>

@@ -21,13 +22,13 @@ document.write('<link id="incognitothemecss" rel="stylesheet" ' +

<span>

<p>

- <span i18n-values=".innerHTML:incognitoTabDescription"></span>

- <a i18n-content="learnMore" i18n-values=".href:learnMoreLink"></a>

+ <span i18n-content="incognitoTabDescription"></span>

</p>

<p>

- <strong i18n-content="incognitoTabWarning"></strong>

+ <span i18n-content="incognitoTabWarning"></span>

</p>

</span>

+ <a i18n-content="learnMore" i18n-values=".href:learnMoreLink"></a>

</div>

</body>

@@ -42,7 +43,9 @@ cr.define('ntp', function() {

document.documentElement.setAttribute('bookmarkbarattached', !!attached);

}

Dan Beam 2015/11/20 00:50:31 /** @param {!{hasCustomBackground: boolean}} theme

Evan Stade 2015/11/20 22:05:17 Done.

- function themeChanged() {

+ function themeChanged(themeData) {

+ document.documentElement.setAttribute('hasCustomBackground',

+ themeData.hasCustomBackground);

document.getElementById('incognitothemecss').href =

'chrome://theme/css/incognito_new_tab_theme.css?' + Date.now();

}