[MD] Change appearance of incognito NTP to MD spec.

chrome/browser/ui/webui/theme_source.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/theme_source.h"
 
 #include "base/memory/ref_counted_memory.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 50 matching lines @@
       scale_factor, data);
 }
 
 }  // namespace
 
 ////////////////////////////////////////////////////////////////////////////////
 // ThemeSource, public:
 
 ThemeSource::ThemeSource(Profile* profile)
     : profile_(profile->GetOriginalProfile()) {
+  // NB: it's important that this is |profile| and not |profile_|.

[Dan Beam, 2015/11/13 01:32:22]

random question: is it too weird to just initialize profile_ afterward?  as in:
move it out of the initializer list?

[Dan Beam, 2015/11/13 01:33:23]

well

  : profile_(nullptr)

  ...

  profile_ = profile->GetOriginalProfile();

[Evan Stade, 2015/11/13 01:39:00]

I guess that would be one way to make this more bullet proof. Although then
someone would come along and ask "why isn't this just in the initializer list?"

[Dan Beam, 2015/11/16 19:57:25]

ok

   NTPResourceCache::WindowType win_type = NTPResourceCache::GetWindowType(
-      profile_, NULL);
+      profile, NULL);
   css_bytes_ =
       NTPResourceCacheFactory::GetForProfile(profile)->GetNewTabCSS(win_type);
 }
 
 ThemeSource::~ThemeSource() {
 }
 
 std::string ThemeSource::GetSource() const {
   return chrome::kChromeUIThemePath;
 }
@@ skipping 165 matching lines @@
   } else {
     DCHECK_CURRENTLY_ON(BrowserThread::IO);
     // Fetching image data in ResourceBundle should happen on the UI thread. See
     // crbug.com/449277
     content::BrowserThread::PostTaskAndReply(
         content::BrowserThread::UI, FROM_HERE,
         base::Bind(&ProcessResourceOnUIThread, resource_id, scale_factor, data),
         base::Bind(callback, data));
   }
 }