Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: trunk/src/chrome/browser/chromeos/drive/drive_system_service.h

Issue 14401006: Revert 195482 "Make DriveSystemService an observer of DriveNotif..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/chrome/browser/chromeos/drive/drive_system_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/chromeos/drive/drive_system_service.h
===================================================================
--- trunk/src/chrome/browser/chromeos/drive/drive_system_service.h (revision 195487)
+++ trunk/src/chrome/browser/chromeos/drive/drive_system_service.h (working copy)
@@ -16,9 +16,9 @@
#include "chrome/browser/chromeos/drive/drive_file_error.h"
#include "chrome/browser/chromeos/drive/drive_file_system_util.h"
#include "chrome/browser/chromeos/drive/drive_scheduler.h"
-#include "chrome/browser/google_apis/drive_notification_observer.h"
#include "chrome/browser/profiles/profile_keyed_service.h"
#include "chrome/browser/profiles/profile_keyed_service_factory.h"
+#include "sync/notifier/invalidation_handler.h"
namespace base {
class FilePath;
@@ -65,9 +65,8 @@
// The class is essentially a container that manages lifetime of the objects
// that are used to run the Drive system. The DriveSystemService object is
// created per-profile.
-class DriveSystemService
- : public ProfileKeyedService,
- public google_apis::DriveNotificationObserver {
+class DriveSystemService : public ProfileKeyedService,
+ public syncer::InvalidationHandler {
public:
// test_drive_service, test_cache_root and test_file_system are used by tests
// to inject customized instances.
@@ -89,9 +88,6 @@
void AddObserver(DriveSystemServiceObserver* observer);
void RemoveObserver(DriveSystemServiceObserver* observer);
- // google_apis::DriveNotificationObserver implementation.
- virtual void OnNotificationReceived() OVERRIDE;
-
google_apis::DriveServiceInterface* drive_service() {
return drive_service_.get();
}
@@ -114,7 +110,16 @@
// Reloads and remounts the file system.
void ReloadAndRemountFileSystem();
+ // Returns true if the push notification is enabled.
+ bool PushNotificationEnabled();
+
private:
+ // syncer::InvalidationHandler implementation.
+ virtual void OnInvalidatorStateChange(
+ syncer::InvalidatorState state) OVERRIDE;
+ virtual void OnIncomingInvalidation(
+ const syncer::ObjectIdInvalidationMap& invalidation_map) OVERRIDE;
+
// Returns true if Drive is enabled.
// Must be called on UI thread.
bool IsDriveEnabled();
@@ -154,6 +159,9 @@
// True if Drive is disabled due to initialization errors.
bool drive_disabled_;
+ // True once this is registered to listen to the Drive updates.
+ bool push_notification_registered_;
+
scoped_refptr<base::SequencedTaskRunner> blocking_task_runner_;
scoped_ptr<EventLogger> event_logger_;
scoped_ptr<DriveCache, util::DestroyHelper> cache_;
« no previous file with comments | « no previous file | trunk/src/chrome/browser/chromeos/drive/drive_system_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698