Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1440053002: Remove duplication between Mandoline and mojo_runner main functions. (Closed)

Created:
5 years, 1 month ago by jam
Modified:
5 years, 1 month ago
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplication between Mandoline and mojo_runner main functions. Committed: https://crrev.com/e43baadd5b88da3fd58b7d5a3f546875bccc46a4 Cr-Commit-Position: refs/heads/master@{#359431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -161 lines) Patch
M mandoline/app/desktop/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D mandoline/app/desktop/launcher_process.h View 1 chunk +0 lines, -15 lines 0 comments Download
D mandoline/app/desktop/launcher_process.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M mandoline/app/desktop/main.cc View 1 chunk +3 lines, -27 lines 0 comments Download
M mojo/runner/BUILD.gn View 2 chunks +7 lines, -2 lines 0 comments Download
M mojo/runner/desktop/launcher_process.h View 1 chunk +6 lines, -1 line 0 comments Download
M mojo/runner/desktop/launcher_process.cc View 3 chunks +13 lines, -10 lines 0 comments Download
M mojo/runner/desktop/main.cc View 1 chunk +2 lines, -28 lines 0 comments Download
A mojo/runner/desktop/main_helper.h View 1 chunk +25 lines, -0 lines 0 comments Download
A + mojo/runner/desktop/main_helper.cc View 2 chunks +30 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
5 years, 1 month ago (2015-11-12 21:15:30 UTC) #2
Ben Goodger (Google)
lgtm
5 years, 1 month ago (2015-11-12 22:58:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440053002/1
5 years, 1 month ago (2015-11-12 23:10:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 23:23:54 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 23:25:20 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e43baadd5b88da3fd58b7d5a3f546875bccc46a4
Cr-Commit-Position: refs/heads/master@{#359431}

Powered by Google App Engine
This is Rietveld 408576698